fix composer.json to allow easier installation#3
Open
fritzmg wants to merge 1 commit intohschottm:masterfrom
Open
fix composer.json to allow easier installation#3fritzmg wants to merge 1 commit intohschottm:masterfrom
fritzmg wants to merge 1 commit intohschottm:masterfrom
Conversation
fritzmg
force-pushed
the
fix-composerjson
branch
from
edc1f9d to
6b7dc30
Compare
|
Please merge this @hschottm. Your version of symfony/framework-bundle clashes with contao 4.8 |
|
@hschottm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the following changes:
symfony/framework-bundledependency, since no component of this bundle is actually used. This enables easier installation of the extension in Contao >4.4.leofeyer/optimize-native-functions-fixerdev dependency since that is already integrated in the PHP CS Fixer.Unrelated question: why do you have your own
ExceptionConverterListener? Is there any specific reason for that? Otherwise you should just simply throw all theContao\CoreBundle\Exception\…exceptions directly.